Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add playback tracking support for mpv-android external player #161

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Add playback tracking support for mpv-android external player #161

merged 1 commit into from
Oct 14, 2020

Conversation

CarlosOlivo
Copy link
Contributor

Closes #149

Note: Release of mpv-android with mpv-android/mpv-android@f70298f not available yet.

@Maxr1998
Copy link
Member

Maxr1998 commented Oct 2, 2020

Nice, thanks for taking care of this! Let me know once it's merged and released in mpv so I can review this 👍

@CarlosOlivo
Copy link
Contributor Author

Nice, thanks for taking care of this! Let me know once it's merged and released in mpv so I can review this 👍

Well, it's already merged, only the release is missing, sorry in advance, I know that asking for ETA is rude, but @sfan5 do you have plans to make a new build release soon? Either way this can wait, there's no rush.

@sfan5
Copy link

sfan5 commented Oct 5, 2020

I assume you don't want to release the support early because it would be confusing to users that the latest version of mpv-android can't actually do playback tracking, is that correct?

@Maxr1998
Copy link
Member

Maxr1998 commented Oct 5, 2020

I think that's the point, yes.

@Maxr1998 Maxr1998 added the enhancement New feature or request label Oct 12, 2020
@sfan5
Copy link

sfan5 commented Oct 13, 2020

Here you go: https://github.com/mpv-android/mpv-android/releases/tag/mpv-android-2020-10-13

@CarlosOlivo
Copy link
Contributor Author

mpv-android requires the extra "position" to be an integer unlike MX & VLC Android that allows long type, so I change that.

@CarlosOlivo CarlosOlivo marked this pull request as ready for review October 14, 2020 00:20
@nielsvanvelzen nielsvanvelzen added this to In progress in v2.1.0 via automation Oct 14, 2020
@nielsvanvelzen nielsvanvelzen merged commit eb6992d into jellyfin:master Oct 14, 2020
v2.1.0 automation moved this from In progress to Done Oct 14, 2020
@CarlosOlivo CarlosOlivo deleted the mpv-playback-tracking branch October 14, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@Maxr1998 Maxr1998 Maxr1998 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
v2.1.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No tracking for mpv-android external player
4 participants
@CarlosOlivo @Maxr1998 @sfan5 @nielsvanvelzen