Handle WebView error on unavailable instance #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/java/org/jellyfin/mobile/fragment/WebViewFragment.kt
Outdated
Show resolved
Hide resolved
CarlosOlivo
force-pushed
the
handle-webview-error
branch
from
41dc515
to
7750e7e
Compare
CarlosOlivo
force-pushed
the
handle-webview-error
branch
from
7750e7e
to
bf73b38
Compare
nielsvanvelzen
approved these changes
Oct 9, 2020
|
I'm not 100% sure why I removed that anymore, but I think I did because my code was a bit oversensitive, showing the error page when only something like a script or JavaScript call failed.. But well, we can merge this and give it a try, if there are to many false positives, we can always revert it again. |
Maxr1998
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assumes that if an error occurs when loading the url of the saved instance, it is not available. Which would redirect the user to the connection fragment instead of showing a WebView error. Similar to previous behavior in v2.0.0-rc.3
Note: This only handles the case when even cache loading fails, #44 still needs to be fixed.
See #44 (comment) #131 #173