Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use view binding in PlayerActivity #201

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Use view binding in PlayerActivity #201

merged 1 commit into from
Oct 19, 2020

Conversation

Maxr1998
Copy link
Member

No description provided.

@Maxr1998 Maxr1998 added enhancement New feature or request exoplayer Related to the ExoPlayer integration code-cleanup/refactor Code cleanup or rework/refactor labels Oct 18, 2020
@Maxr1998 Maxr1998 added this to In progress in v2.1.0 via automation Oct 18, 2020
@CarlosOlivo
Copy link
Contributor

#189

@Maxr1998
Copy link
Member Author

#189

Not needed (yet) because this is still an Activity. I will switch this to a fragment in another PR, wanted to split this up a bit.

@nielsvanvelzen nielsvanvelzen merged commit d4effb5 into master Oct 19, 2020
v2.1.0 automation moved this from In progress to Done Oct 19, 2020
@nielsvanvelzen nielsvanvelzen deleted the player-viewbinding branch October 19, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
code-cleanup/refactor Code cleanup or rework/refactor enhancement New feature or request exoplayer Related to the ExoPlayer integration
Projects
No open projects
v2.1.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Maxr1998 @CarlosOlivo @nielsvanvelzen