Migrate server and user info to database #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
added
enhancement
Maxr1998
force-pushed
the
server-db
branch
3 times, most recently
from
d9272c6
to
08c142a
Compare
Maxr1998
commented
Oct 31, 2020
nielsvanvelzen
requested changes
Nov 1, 2020
nielsvanvelzen
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a bit bigger than I would've liked, but I had to change quite a few things to get this in. Also fixed some other things in the
MediaServicethat I noticed. E.g. thesendError()would always crash the app in this form, as it's only used for custom commands withinMediaBrowserCompatService. Instead, we just return a null result.