Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version code calculation comment #228

Merged
merged 1 commit into from Nov 10, 2020

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Nov 6, 2020

Each part of the semver should be able to use 2 digits. It didn't do that for PATCH.

Kotlin-playground test: https://pl.kotl.in/kwvS88jHC

@nielsvanvelzen nielsvanvelzen added this to In progress in v2.2.0 via automation Nov 6, 2020
@nielsvanvelzen
Copy link
Member Author

nielsvanvelzen commented Nov 7, 2020

@Artiume I think you mentioned this PR per accident in the know issues list fyi

edit: it might have pointed to the old android app and GitHub did something weird

@nielsvanvelzen nielsvanvelzen force-pushed the fix-vercode-calc branch 2 times, most recently from f2fb50a to 68fe144 Compare November 7, 2020 09:05
@nielsvanvelzen nielsvanvelzen changed the title Fix version code calculation Fix version code calculation comment Nov 7, 2020
@nielsvanvelzen
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you could maybe still remove leading zeros from the version codes.

@Maxr1998 Maxr1998 merged commit 1522c71 into jellyfin:master Nov 10, 2020
v2.2.0 automation moved this from In progress to Done Nov 10, 2020
@nielsvanvelzen nielsvanvelzen deleted the fix-vercode-calc branch November 22, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants