-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebView: Use timber for logging #323
Merged
Maxr1998
merged 1 commit into
jellyfin:master
from
Codex-:feature/webview_timber_logging
Mar 24, 2021
Merged
WebView: Use timber for logging #323
Maxr1998
merged 1 commit into
jellyfin:master
from
Codex-:feature/webview_timber_logging
Mar 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
requested changes
Mar 20, 2021
app/src/main/java/org/jellyfin/mobile/fragment/WebViewFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/mobile/fragment/WebViewFragment.kt
Outdated
Show resolved
Hide resolved
Codex-
force-pushed
the
feature/webview_timber_logging
branch
from
March 20, 2021 14:30
945ab95
to
2ee6cba
Compare
app/src/main/java/org/jellyfin/mobile/fragment/WebViewFragment.kt
Outdated
Show resolved
Hide resolved
Codex-
force-pushed
the
feature/webview_timber_logging
branch
from
March 20, 2021 23:07
2ee6cba
to
9581573
Compare
Not sure what's happening with the agent:
|
Those messages should be fine. Azure just randomly crashes occasionally, restarted the pipeline so it hopefully passes now. |
Maxr1998
changed the title
WebView: Use timber for logging.
WebView: Use timber for logging
Mar 21, 2021
nielsvanvelzen
previously approved these changes
Mar 22, 2021
Maxr1998
requested changes
Mar 22, 2021
app/src/main/java/org/jellyfin/mobile/fragment/WebViewFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/mobile/fragment/WebViewFragment.kt
Outdated
Show resolved
Hide resolved
Codex-
force-pushed
the
feature/webview_timber_logging
branch
from
March 24, 2021 00:59
9581573
to
5c56c23
Compare
Codex-
force-pushed
the
feature/webview_timber_logging
branch
from
March 24, 2021 01:06
5c56c23
to
6387bf4
Compare
Rebased and resolved conflicts. |
nielsvanvelzen
approved these changes
Mar 24, 2021
Maxr1998
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found during my last PR that all logs despite the level used in the JS layer would always go to the info level when logged in logcat.
This change simply overrides the
onConsoleMessage
method to log messages to the correct level.This allows you to use the logcat filtering in IntelliJ/Android Studio to filter for logs normally and makes the messages less verbose.
The new messages are tagged with
WebView
and follow the original messages format, although happy to change any of this :)Old:
New: