Migrate ExoPlayer to SDK and decouple from webapp #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
added
documentation
Maxr1998
force-pushed
the
exoplayer-native-playback
branch
2 times, most recently
from
9764299
to
ad02686
Compare
app/src/main/java/org/jellyfin/mobile/player/PlayerNotificationHelper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/mobile/player/source/JellyfinMediaSource2.kt
Outdated
Show resolved
Hide resolved
Maxr1998
force-pushed
the
exoplayer-native-playback
branch
from
ad02686
to
64d077b
Compare
Maxr1998
force-pushed
the
exoplayer-native-playback
branch
from
64d077b
to
e1fb40f
Compare
nielsvanvelzen
previously approved these changes
May 6, 2021
Now uses the new Kotlin SDK to resolve media metadata, create the device profile, initialise playback and report playback progress/events. Playlists are supported and handled by the app. For the external player, there's still some communication with the webapp necessary. Smaller changes: - Media sessions now always show a notification, not only when in background - The notification has a skip to previous/next button when playing a playlist now instead of seek - Playback progress is only reported regularly when media is playing - The fullscreen-switcher on portrait videos now has the correct initial state - Factories for ExoPlayer data sources are injected with Koin
Maxr1998
force-pushed
the
exoplayer-native-playback
branch
from
e1fb40f
to
5a056a7
Compare
nielsvanvelzen
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now uses the new Kotlin SDK to resolve media metadata, create the device profile, initialise playback and report playback progress/events.
Supports playlists.
Smaller changes: