Replace GH_TOKEN with JF_BOT_TOKEN #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you're at it, can you add the token to gradlew-update.yaml too? |
ferferga
changed the title
|
@nielsvanvelzen Done! |
nielsvanvelzen
requested changes
May 13, 2021
Maxr1998
approved these changes
May 13, 2021
nielsvanvelzen
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH_TOKENseems to be used internally by GitHub and it's making some actions we're using in some repos fail (Source)(PRs made from users of the org are always successful, but PRs that aren't don't work, like Dependabot PRs. This can be checked by looking at the history of server repos and Jellyfin Vue)
The org-wide secret should be renamed to something else to avoid confusion and further replacements or messes in GH's side. This PR replaces
GH_TOKENwithJF_BOT_TOKEN, which should be pretty generic.