Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework connection layout and show loading indicator while connecting to server #396

Merged
merged 8 commits into from
May 23, 2021

Conversation

fedesenmartin
Copy link
Contributor

Added loading indicator while connecting to host

@fedesenmartin fedesenmartin changed the title Connect Screen Loading Indicator Connect Screen Loading Indicator enhancement May 21, 2021
@fedesenmartin fedesenmartin changed the title Connect Screen Loading Indicator enhancement Connect Screen Loading Indicator May 21, 2021
Maxr1998
Maxr1998 previously approved these changes May 23, 2021
Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I used the occasion to also make some other tweaks to the connection layout.

@Maxr1998
Copy link
Member

Maxr1998 commented May 23, 2021

It looks like this now:

@Maxr1998 Maxr1998 changed the title Connect Screen Loading Indicator Rework connection layout and show loading indicator while connecting to server May 23, 2021
@Maxr1998 Maxr1998 enabled auto-merge (squash) May 23, 2021 19:55
@Maxr1998 Maxr1998 merged commit 1e0e968 into jellyfin:master May 23, 2021
@nielsvanvelzen nielsvanvelzen added this to In progress in v2.3.0 via automation May 23, 2021
@nielsvanvelzen nielsvanvelzen moved this from In progress to Done in v2.3.0 May 23, 2021
@nielsvanvelzen nielsvanvelzen added the backport Pull request needs to be backported to current release branch label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull request needs to be backported to current release branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants