Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect rsync options #398

Merged
merged 1 commit into from
May 23, 2021

Conversation

h1dden-da3m0n
Copy link
Contributor

Description

With the deployment/release of the Android app we ran into a few issues with the new GitHub actions based workflow, most of which got already fixed but apparently I messed up the rsyncoptions in my initial PR 🤦‍♂️.
This PR aims to fix that and hopefully get the workflow 100% operational for the next release.

Changes

  • remove obsolete/release breaking rsync options

Issues

  • n/a?

@h1dden-da3m0n h1dden-da3m0n marked this pull request as draft May 22, 2021 23:45
.github/workflows/app-publish.yaml Outdated Show resolved Hide resolved
@h1dden-da3m0n h1dden-da3m0n marked this pull request as ready for review May 23, 2021 00:51
Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That should work now, hopefully. 🤞

@Maxr1998 Maxr1998 merged commit 3a69f37 into jellyfin:master May 23, 2021
@h1dden-da3m0n h1dden-da3m0n deleted the fix_deploy_upload branch May 23, 2021 01:17
@nielsvanvelzen nielsvanvelzen added this to In progress in v2.3.0 via automation May 23, 2021
@nielsvanvelzen nielsvanvelzen added the backport Pull request needs to be backported to current release branch label May 23, 2021
@nielsvanvelzen nielsvanvelzen moved this from In progress to Done in v2.3.0 May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull request needs to be backported to current release branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants