Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember brightness changes on ExoPlayer #442

Merged

Conversation

CarlosOlivo
Copy link
Contributor

Closes #418

@Maxr1998 Maxr1998 self-requested a review June 17, 2021 23:57
@Maxr1998 Maxr1998 added enhancement New feature or request exoplayer Related to the ExoPlayer integration labels Jun 18, 2021
@Maxr1998 Maxr1998 added this to In progress in v2.3.0 via automation Jun 18, 2021
@Maxr1998 Maxr1998 force-pushed the brightness-changes-native-player branch from c80d901 to 3c1cf5f Compare June 19, 2021 15:34
@Maxr1998 Maxr1998 force-pushed the brightness-changes-native-player branch from 3c1cf5f to 4a2448f Compare June 19, 2021 15:35
@Maxr1998 Maxr1998 enabled auto-merge (squash) June 19, 2021 15:36
@Maxr1998 Maxr1998 merged commit f487071 into jellyfin:master Jun 19, 2021
v2.3.0 automation moved this from In progress to Done Jun 19, 2021
@CarlosOlivo CarlosOlivo deleted the brightness-changes-native-player branch June 19, 2021 15:41
@CarlosOlivo
Copy link
Contributor Author

Not necessary, but I was thinking that rememberBrightnessPreference should be disabled if swipeGesturesPreference is not enabled.

@Maxr1998
Copy link
Member

Good point. Do you want to draft another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exoplayer Related to the ExoPlayer integration
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Native Player: Remember Brightness
2 participants