Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer changing refresh rate without changing resolution #1484

Merged

Conversation

mueslimak3r
Copy link
Member

@mueslimak3r mueslimak3r commented Mar 3, 2022

Changes

  • modes that have the same resolution as the default mode will rank higher than other modes. This will hopefully result in the resolution changing in addition to the refresh rate only if there are no other options.

Issues
#1482

Notes

  • My display doesn't support the refresh rates needed for this feature. Someone else will need to test it.

@mueslimak3r mueslimak3r force-pushed the refresh-rate-prefer-default-res branch from 4f953aa to 12a260f Compare March 7, 2022 07:47
@nielsvanvelzen nielsvanvelzen added this to In progress in v0.14.0 via automation Mar 7, 2022
@nielsvanvelzen nielsvanvelzen added the next-release Pull request related to a future release which is not being worked on yet label Mar 7, 2022
@mueslimak3r mueslimak3r force-pushed the refresh-rate-prefer-default-res branch from 7460a00 to 0626883 Compare March 8, 2022 08:33
@nielsvanvelzen nielsvanvelzen removed the next-release Pull request related to a future release which is not being worked on yet label Mar 17, 2022
@mueslimak3r mueslimak3r force-pushed the refresh-rate-prefer-default-res branch from 0626883 to 2242fca Compare March 19, 2022 21:07
@mueslimak3r mueslimak3r marked this pull request as ready for review March 19, 2022 21:07
v0.14.0 automation moved this from In progress to Reviewer approved Mar 19, 2022
@nielsvanvelzen nielsvanvelzen merged commit be89cf2 into jellyfin:master Mar 19, 2022
v0.14.0 automation moved this from Reviewer approved to Done Mar 19, 2022
@nielsvanvelzen nielsvanvelzen added this to In progress in v0.13.1 via automation Mar 19, 2022
@nielsvanvelzen nielsvanvelzen removed this from Done in v0.14.0 Mar 20, 2022
@nielsvanvelzen nielsvanvelzen moved this from In progress to Done in v0.13.1 Mar 20, 2022
@nielsvanvelzen nielsvanvelzen moved this from Done to Cherrypicked in v0.13.1 Mar 23, 2022
@mueslimak3r mueslimak3r deleted the refresh-rate-prefer-default-res branch April 12, 2022 08:08
@KyleSanderson
Copy link

@nielsvanvelzen can you revert this? This damages every single user not on a shield as they can't use their TV upscaler anymore.

@mueslimak3r
Copy link
Member Author

mueslimak3r commented Apr 25, 2022

This damages every single user not on a shield as they can't use their TV upscaler anymore.

Which device are you using?
It's interesting that it broke the upscaler for you but fixed the upscaler for the user who opened #1482

@KyleSanderson
Copy link

This damages every single user not on a shield as they can't use their TV upscaler anymore.

Which device are you using? It's interesting that it broke the upscaler for you but fixed the upscaler for the user who opened #1482

Using the refresh rate switch on 4K display when playing 720p/1080p media, the refresh rate is switched to match the video as intended, but the display resolution also switch to 1080p which will block the needed upscale from the nvidia shield.

I do not want to use my device upscaler. My TV is the correct upscaler, as it is for everyone outside of Shield users. The native resolution going to the TV is correct, and should be a "disable" for Shield users as an opt-in only as it's absolutely not desirable behaviour.

@Dnkhatri
Copy link

I think Kodi implementation of whitelist for resolution and refresh rate matching would probably the best way to go.

xbmc/xbmc#13274
xbmc/xbmc#16216

@nielsvanvelzen
Copy link
Member

@KyleSanderson can you open a new issue for your problem? It's easier to track then in the comments of a merged PR. I guess the "easy" solution for now is to have 2 toggles; one for refresh rate switching and one for resolution switching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v0.13.1
Cherrypicked
Development

Successfully merging this pull request may close these issues.

None yet

4 participants