Make cancel default on delete/clear #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select cancel so a user doesn't accidentally delete media by hitting delete twice. Since we ask it's worth adding this extra step, if we need to remove the extra step it's arguable we can completely remove alert dialog all-together
This reduces the verbosity and boilerplate around the methods. It makes sense to do these whilst we're touching the code.
mueslimak3r
approved these changes
Mar 22, 2022
nielsvanvelzen
approved these changes
Mar 22, 2022
|
Some while ago we discussed the delete function and I believe we decided the app shouldn't have a delete button for items. So we'll probably remove it at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Select cancel by default on confirmation dialog
Select cancel so a user doesn't accidentally delete media by hitting
delete twice. Since we ask it's worth adding this extra step, if we need
to remove the extra step it's arguable we can completely remove alert
dialog all-together
Testing
Ensure that the user account can delete media