libVLC: Switch to using audio time stretching by default #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches libVLC's normal default. Looking back in the project history this was set to no stretching from the very start @commit 9528b9a Since libVLC use it by default and this wasn't a bug fix I propose we can opt in the audio stretching by default. This should only trigger when a user selects a playback speed that isn't 1x anyway.
DavidFair
changed the title
mueslimak3r
approved these changes
Mar 27, 2022
nielsvanvelzen
approved these changes
Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This matches libVLC's normal default. Looking back in the project
history this was set to no stretching from the very start @commit
9528b9a
Since libVLC uses it by default and this wasn't a bug fix I propose we
can opt in the audio stretching by default. This should only trigger when
a user selects a playback speed that isn't 1x anyway.
For future reference, the original changeset was here:
9528b9a#diff-226bb739f67bb7dbde6485e2433c55b1cc25fff3fea24029e5344b0c396657b6R232
Issues
None on GitHub, but I have seen it mentioned on Reddit and I was planning on doing this anyway so...
Testing