Refactor play logic in PlaybackController #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidFair
force-pushed
the
Refactor_play_logic
branch
from
f26f1fe
to
c228180
Compare
mueslimak3r
requested changes
Apr 2, 2022
Since we will be touching this code in a later commit it makes sense to extract these into private methods as-is. This commit only extracts the options and does not perform any additional refactoring steps
Since we are doing this three times we can simply move it out of these methods. This makes it easier for us to calculate a dynamic bitrate later.
This one was noticed during refactoring and it's fairly free. Now we use a float (rather than a Float object) the nullable annotation is incorrect.
DavidFair
force-pushed
the
Refactor_play_logic
branch
from
c228180
to
48ac996
Compare
mueslimak3r
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PlaybackController:playinto private methods. This first step was done as-is so no modifications were made to the actual methodsUtils.getMaxBitrateto a single locationThis is a precursor to #1569 and should allow us to:
VideoOptionswhen the replacementTesting