Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ASPECT_RATIO_BANNER again #1590

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Fix ASPECT_RATIO_BANNER again #1590

merged 1 commit into from
Mar 31, 2022

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Mar 31, 2022 •
edited

This is the banner I used:

image

This is how it looked in 0.13.2

image

And this is how it looks after my new fix:

image

Changes

  • Fix ASPECT_RATIO_BANNER again
    • 1000/185=5
    • 1000.0/185.0=5.4054054054-ish

Issues

@nielsvanvelzen nielsvanvelzen added this to In progress in v0.13.3 via automation Mar 31, 2022
v0.13.3 automation moved this from In progress to Reviewer approved Mar 31, 2022
@thornbill thornbill merged commit d890b44 into jellyfin:master Mar 31, 2022
v0.13.3 automation moved this from Reviewer approved to Done Mar 31, 2022
@nielsvanvelzen nielsvanvelzen deleted the double-trouble branch March 31, 2022 19:54
@nielsvanvelzen nielsvanvelzen moved this from Done to Cherrypicked in v0.13.3 Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v0.13.3
Cherrypicked
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

banners still miss parts after update to 0.13.2
2 participants
@nielsvanvelzen @thornbill