Add showing additional parts #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dspencer001
force-pushed
the
additional-parts
branch
from
0830f36
to
d3bbcbb
Compare
nielsvanvelzen
requested changes
Jun 13, 2022
app/src/main/java/org/jellyfin/androidtv/data/querying/AdditionalPartsQuery.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapter.java
Show resolved
Hide resolved
dspencer001
force-pushed
the
additional-parts
branch
from
d3bbcbb
to
23a9504
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/org/jellyfin/androidtv/data/querying/AdditionalPartsQuery.java
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/data/querying/AdditionalPartsQuery.java
Fixed
Show fixed
Hide fixed
| @@ -279,6 +281,14 @@ | |||
| queryType = QueryType.Specials; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, AdditionalPartsQuery query, Presenter presenter, ArrayObjectAdapter parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness
| @@ -279,6 +281,14 @@ | |||
| queryType = QueryType.Specials; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, AdditionalPartsQuery query, Presenter presenter, ArrayObjectAdapter parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness
| @@ -279,6 +281,14 @@ | |||
| queryType = QueryType.Specials; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, AdditionalPartsQuery query, Presenter presenter, ArrayObjectAdapter parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness
| @@ -279,6 +281,14 @@ | |||
| queryType = QueryType.Specials; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, AdditionalPartsQuery query, Presenter presenter, ArrayObjectAdapter parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness
app/src/main/java/org/jellyfin/androidtv/data/querying/AdditionalPartsQuery.kt
Fixed
Show fixed
Hide fixed
nielsvanvelzen
requested changes
Jul 7, 2022
app/src/main/java/org/jellyfin/androidtv/data/querying/AdditionalPartsQuery.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapter.java
Outdated
Show resolved
Hide resolved
|
Do you want me to add the |
nielsvanvelzen
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds showing Additional parts above Cast / Crew for Movies. Includes what translations I could get from jellyfin-web. I have very limited Android app experience, so this is mostly copied from how the specials and suggestions are retrieved and displayed. Tested with Lord of the Rings extended editions on an Nvidia Shield TV Pro.