New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix series logo scaling in player #1876

Merged

nielsvanvelzen merged 1 commit into jellyfin:master from mueslimak3r:player-series-logo-fix

Jul 22, 2022

Member

mueslimak3r commented Jul 22, 2022

Changes

adjust logo/title margins so the logo only has a 2dp bottom margin but the title text still has 8dp
constrain the logo to a max width of 450dp
copied some other properties from mainImage in view_row_details.xml which is used to display an item logo or poster in FullDetailsActivity.
use fitCenter scaling to fill the view. (this was useful when testing with SVGs since they needed to be scaled. SVG support is not included in this PR)

Issues

series logos would sometimes be far too large (I've seen some that take up half the screen horizontally)

Notes

I'm not super knowledgable about layouts so hopefully someone with more experience can give feedback on whether they are used correctly here, and if some aren't needed.


          fix series logo scaling in player

7c2cfde

mueslimak3r added the bug label

nielsvanvelzen approved these changes

View reviewed changes

Member

nielsvanvelzen left a comment

Layout changes look fine!

nielsvanvelzen added this to In progress in v0.14.0 via automation

nielsvanvelzen merged commit c3d75c7 into jellyfin:master

v0.14.0 automation moved this from In progress to Done

mueslimak3r deleted the player-series-logo-fix branch

July 22, 2022 21:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment