handle exoplayer track selection indexes starting at 1 #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
requested changes
Jul 22, 2022
app/src/main/java/org/jellyfin/androidtv/ui/playback/VideoManager.java
Outdated
Show resolved
Hide resolved
mueslimak3r
force-pushed
the
exoplayer-track-selection-indexing-fix
branch
from
3e68062
to
78bd8d3
Compare
nielsvanvelzen
approved these changes
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
offsetStreamIndex()can now account for a players indexing from 1 (exoplayer starts at 1, libVLC starts at 0)truewhen trying to set a track with exoplayer and it is already selected. Returning false indicates an error/that transcoding may be needed so the stream is recreated, and that is not needed in this situation.Issues
mentioned here:
fix player track selection - offset MediaStream indexes to account for external tracks #1732 (comment)