Replace string usages for BaseItemDto.Type with the EBaseItemType #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixing dependency substitution now that we use explicit versions
|
I'm going to rebase this on master and force push to resolve the conflicts. |
thornbill
force-pushed
the
typestring-to-enum
branch
from
e9eec9e
to
d0272cc
Compare
thornbill
requested changes
Dec 23, 2019
app/src/main/java/org/jellyfin/androidtv/itemhandling/ItemRowAdapter.java
Show resolved
Hide resolved
thornbill
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixing dependency substitution now that we use explicit versions
This depends on the related PR jellyfin/jellyfin-sdk-kotlin#30 , which should be made available as release v0.5.0 before this is merged.
I'm sorry for the person that reviews this and makes sure that all conditional replacements are correct, it was a pain for me to write and review before sending the PR as well :(
Luckily this has to be done only once :)