Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid id reference causing lintVitalRelease to fail #272

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Fix invalid id reference causing lintVitalRelease to fail #272

merged 1 commit into from
Jan 23, 2020

Conversation

thornbill
Copy link
Member

The programImage id did not exist in this layout which caused the release build to fail linting when running assembleRelease, but not when running build.

but why

nielsvanvelzen
nielsvanvelzen approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how Android checks those things only on releases while most projects automate it in CI so you only notice it when doing a release lol

@nielsvanvelzen nielsvanvelzen merged commit 8a2edbc into jellyfin:master Jan 23, 2020
@thornbill thornbill deleted the fix-release branch January 23, 2020 18:43
@nielsvanvelzen nielsvanvelzen added this to In progress in v0.11.0 via automation Jan 28, 2020
@nielsvanvelzen nielsvanvelzen moved this from In progress to Done in v0.11.0 Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v0.11.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thornbill @nielsvanvelzen