Check if fragment is null in PlaybackController.play #3475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
bug
thornbill
reviewed
Mar 30, 2024
app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackController.java
Outdated
Show resolved
Hide resolved
thornbill
approved these changes
Mar 30, 2024
nielsvanvelzen
added a commit
that referenced
this pull request
Apr 7, 2024
* Check if fragment is null in PlaybackController.play * Update logging levels in PlaybackController (cherry picked from commit d22ab69)
nielsvanvelzen
removed
the
backportable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had a lot of null checks in this function but some branches still tried to use mFragment causing a NPE. Refactored the function to check for null once in the top and return if is it null.
Changes
Check if fragment is null in PlaybackController.play and noop if it is.
Issues
Fixes #3471