Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ActivityLifecycleCallbacks implementation to check for null current user #374

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Add ActivityLifecycleCallbacks implementation to check for null current user #374

merged 1 commit into from
Mar 5, 2020

Conversation

thornbill
Copy link
Member

Fixes #325

its happening

@thornbill thornbill added this to In progress in v0.12.0 via automation Mar 3, 2020
@thornbill thornbill requested a review from AndreasGB March 3, 2020 21:23
nielsvanvelzen
nielsvanvelzen requested changes Mar 4, 2020
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. One note we discussed on matrix already.

app/src/main/java/org/jellyfin/androidtv/base/AuthenticatedUserCallbacks.kt Show resolved Hide resolved
@AndreasGB AndreasGB merged commit eaff7f8 into jellyfin:master Mar 5, 2020
v0.12.0 automation moved this from In progress to Done Mar 5, 2020
@thornbill thornbill added this to In progress in v0.11.2 via automation Mar 9, 2020
@thornbill thornbill moved this from In progress to Done in v0.11.2 Mar 9, 2020
@thornbill thornbill removed this from Done in v0.12.0 Mar 11, 2020
@thornbill thornbill deleted the the-clock-crash branch March 11, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@AndreasGB AndreasGB AndreasGB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v0.11.2
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on re-entring the app if its process has been killed by Android in the meantime (aka The Clock Crash)
3 participants
@thornbill @nielsvanvelzen @AndreasGB