Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ConnectionManager intialization #468

Merged
merged 6 commits into from May 2, 2020
Merged

Refactor ConnectionManager intialization #468

merged 6 commits into from May 2, 2020

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Apr 30, 2020 •
edited

Changes

  • Adds a ConnectionManagerRepository singleton to handle initialization of the ConnectionManager
  • Adds SerializerRepository singleton to handle the GsonJsonSerializer
  • Moves initialization of PlaybackManager to TvApp
  • Adds constants for common extras values

Issues
N/A

@thornbill thornbill added this to In progress in v0.12.0 Apr 30, 2020
@codeclimate
Copy link

codeclimate bot commented Apr 30, 2020

Code Climate has analyzed commit 4bad5ed and detected 18 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 18

View more on Code Climate.

@thornbill thornbill marked this pull request as ready for review April 30, 2020 21:22
@thornbill
Copy link
Member Author

I think this is ready for review now. I will address the logging changes in a separate PR.

@nielsvanvelzen nielsvanvelzen self-requested a review May 1, 2020 07:42
nielsvanvelzen
nielsvanvelzen requested changes May 1, 2020
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, one comment about the extra's changes.

I don't really like the singletons but those can (and will) be solved when we implement dependency injection.

app/src/main/java/org/jellyfin/androidtv/constants/Extras.kt Show resolved Hide resolved
@thornbill thornbill mentioned this pull request May 2, 2020
Merged
@nielsvanvelzen nielsvanvelzen merged commit 15887a6 into jellyfin:master May 2, 2020
v0.12.0 automation moved this from In progress to Done May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v0.12.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thornbill @nielsvanvelzen