WIP - need your reviews #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably getting closed soon. But I'm curious, what's the source, what's the license status there and is it anything that we should want? |
|
I think at least it needs to be broken into manageable commits. The PR should also hold information about what changed.. Thanks for the find! |
|
No promises though, the other people here will probably think about it :) |
|
Great find! I have opened #58 which is based on the same branch with Jellyfin’s changes merged in which maintains the git history. I am closing this PR since it does not preserve the history. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the PR Updated from highattack30 dev branch