Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor player profiles #899

Merged
merged 11 commits into from May 21, 2021
Merged

Refactor player profiles #899

merged 11 commits into from May 21, 2021

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented May 17, 2021 •
edited

Changes

  • Moves device profile classes to a new profile package
  • Moves each player profile to an individual class
  • Refactors ProfileHelper in Kotlin

Issues
N/A

@thornbill thornbill force-pushed the separate-profiles branch 2 times, most recently from f134281 to 7620450 Compare May 17, 2021 19:51
@thornbill thornbill marked this pull request as ready for review May 18, 2021 15:31
@thornbill thornbill added this to In progress in v0.12.0 via automation May 18, 2021
nielsvanvelzen
nielsvanvelzen requested changes May 18, 2021
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review ExoPlayerProfile, ExternalPlayerProfile and LibVlcProfile yet, but those are probably fine

app/src/main/java/org/jellyfin/androidtv/util/profile/BaseProfile.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/BaseProfile.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ProfileHelper.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ProfileHelper.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ProfileHelper.kt Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ProfileHelper.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ProfileHelper.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ProfileHelper.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ProfileHelper.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ProfileHelper.kt Outdated Show resolved Hide resolved
nielsvanvelzen
nielsvanvelzen reviewed May 19, 2021
View reviewed changes
app/src/main/java/org/jellyfin/androidtv/util/profile/LibVlcProfile.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/LibVlcProfile.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/LibVlcProfile.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ExoPlayerProfile.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ExoPlayerProfile.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ExoPlayerProfile.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ExoPlayerProfile.kt Outdated Show resolved Hide resolved
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label May 19, 2021
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label May 21, 2021
@nielsvanvelzen nielsvanvelzen merged commit d9afe54 into jellyfin:master May 21, 2021
v0.12.0 automation moved this from In progress to Done May 21, 2021
@thornbill thornbill deleted the separate-profiles branch May 21, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v0.12.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thornbill @nielsvanvelzen @jellyfin-bot