Incremental music sync log errors

[mcarlton00]

Describe the bug

New music added to the server while music isn't synced -> Lots of errors in the logs

2020-04-08 20:06:13.443 T:140039749101312  NOTICE: JELLYFIN.objects.music -> ERROR::jellyfin_kodi/objects/music.py:392 'NoneType' object has no attribute '__getitem__'
                                            Traceback (most recent call last):
                                              File "jellyfin_kodi/objects/music.py", line 390, in song_artist_link
                                                temp_obj['ArtistId'] = self.jellyfin_db.get_item_by_id(*values(temp_obj, QUEM.get_item_obj))[0]
                                            TypeError: 'NoneType' object has no attribute '__getitem__'

Seems to be based around repeatedly trying to look up the item in the database when it doesn't exist.

System (please complete the following information):

• Jellyfin Version: 10.5.3
• Kodi Version: 18.6
• Addon Version: 0.5.3

[mcarlton00]

A lot of this is caused by the code surrounding the database. It's trying to sync everything, finding out that the library shouldn't be synced, but then not stopping the process so it throws a bunch of errors. There's also a lot of program flow being determined by try/except blocks around here:

jellyfin-kodi/jellyfin_kodi/objects/music.py

Lines 195 to 204 in 66ef0a5

	try:
	temp_obj['ArtistId'] = self.jellyfin_db.get_item_by_id(*values(temp_obj, QUEM.get_item_obj))[0]
	except TypeError:
	try:
	self.artist(self.server.jellyfin.get_item(temp_obj['Id']), library=None)
	temp_obj['ArtistId'] = self.jellyfin_db.get_item_by_id(*values(temp_obj, QUEM.get_item_obj))[0]
	except Exception as error:
	LOG.exception(error)
	continue

[mcarlton00]

Still seeing this. It's harmless, but annoying

Edit: happening during the notification events from the server when metadata is changed, not during the incremental sync on startup.