Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to connect to IPv6 addresses directly #79

Closed
TrueTechy opened this issue Sep 19, 2019 · 2 comments · Fixed by #103
Closed

Fails to connect to IPv6 addresses directly #79

TrueTechy opened this issue Sep 19, 2019 · 2 comments · Fixed by #103
Labels
bug Something isn't working
Projects

Comments

@TrueTechy
Copy link
Contributor

Describe the bug
Addon cannot connect to server if given address is an IPv6 address

To Reproduce

  1. Enter ::1 in host section
  2. Click connect

Expected behavior
Addon connects to server

Logs
InvalidURL: Failed to parse: http://::1:9898/emby/system/info/public

System (please complete the following information):

  • OS: Ubuntu
  • Jellyfin Version: 10.4
  • Kodi Version: 18.3
  • Addon Version: 0.2.1

Additional context
Seem to be due to the request not properly encapsulating the IPv6 address since it has a port on it as well. Should be enclosed by square brackets https://softwareengineering.stackexchange.com/questions/311413/how-should-we-represent-an-ipv6-address-with-port-number-in-text

@TrueTechy
Copy link
Contributor Author

#94 seems to make the add-on crash when adding an IPv6 address, I assume because it's expecting a domain name. It may also not like v4 addresses haven't tested those

@oddstr13
Copy link
Member

oddstr13 commented Oct 3, 2019

Please test #103, it should solve this issue

@oddstr13 oddstr13 added this to To do in IPv6 via automation Apr 19, 2020
@oddstr13 oddstr13 moved this from To do to Done in IPv6 Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
IPv6
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants