Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipintro causes player progress to be stuck #387

Closed
MarcelBochtler opened this issue Mar 3, 2023 · 3 comments
Closed

Skipintro causes player progress to be stuck #387

MarcelBochtler opened this issue Mar 3, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@MarcelBochtler
Copy link

MarcelBochtler commented Mar 3, 2023

Describe the bug
When Skipintro is enabled, the seekbar doesn't show playback time anymore, and playback progress is no longer persisted.
A restart of the application fixes the issue. Basically the first video always works fine, but the second one and all after that show this bug.
When Skipintro is disabled, I cannot reproduce this anymore.

To Reproduce
Steps to reproduce the behavior:

  1. Enable Skipintro
  2. Restart Jellyfin Media Player
  3. Start a video (I guess one that has been progressed by skipintro before)
  4. Stop the video by clicking the back button on the top left
  5. Start the same video again. Now the seek bar only shows --:-- on mouse over, the playback progress is no longer stored / reported to the server, the seek bar doesn't even move anymore.

Expected behavior
The seek bar should show the current progress of the video and store the progress on the server.

Screenshots
SCR-20230303-vzp

Desktop (please complete the following information):

  • Device: MacBook M1 Max 2021 14"
  • OS: macOS 13.2.1 arm 64
  • Version: Jellyfin Media Player 1.8.1
  • Installation Method: macOS installer
@MarcelBochtler MarcelBochtler added the bug Something isn't working label Mar 3, 2023
@iwalton3
Copy link
Member

iwalton3 commented Mar 4, 2023

This will be fixed in the next release. You can download the fixed plugin and place it in your extension folder now to test the fix: https://raw.githubusercontent.com/jellyfin/jellyfin-media-player/b963836c18cf6d440979319bdb50d301158829ae/native/skipIntroPlugin.js

@iwalton3
Copy link
Member

iwalton3 commented Mar 4, 2023

You can also download a test build here: https://github.com/jellyfin/jellyfin-media-player/actions/runs/4329606956

@MarcelBochtler
Copy link
Author

Yes, that test build fixes the issue. Thanks for fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants