-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Borderless Fullscreen #37
Comments
This has been added and will be in the next release. You can verify/use the fix prior to release with this dev build: https://iwalton.com/ushare/jellyfin-mpv-desktop_test_issue37.exe |
That looks Much better! Although, two small issues. In tv mode (didn't test in desktop mode)
A menu option to exit may be necessary. Also the next ticket I would make (but I'll mention it here) is a switch user option. Preferably one without requiring a password considering multiple people are going to use this without a keyboard (or a way to remember user password once it's entered). Again, this could be my lack of knowledge of jellyfin. In the browser version I couldn't find a way to switch users either. So I'm assuming that's an oversight on their part. But in the browser version in the hamburger menu there is a sign out option. An exit option would be great and it would be nice to have a switch user option and well another screen to select users. I currently have 2 users set up but the only way currently is to sign out then type in the new user and password. Not great when just using a remote :) |
The user switching issue should be logged against https://github.com/jellyfin/jellyfin-web, as that is the upstream web client project. |
You're using their infrastructure for desktop client? let me rephrase a bit, so if they add the switch user option, are you able to have the desktop client retain the password to make it possible to switch without breaking out the keyboard? ;) Also I posted on the site you linked. We'll see what they say. |
Yes, I'm embedding the web client currently with a fairly minimal patch set to allow it to connect to the MPV system. As far as I know, fast user switching isn't available in the web client, but there is a feature request. Adding a feature such as user switching isn't something I would really want to do right now. The web client is due to be re-written in something more manageable. It is currently a headache for me to understand and add features to, as it is all plain JavaScript with no framework. If upstream adds it though it would be easy for me to update the client to support it. I will probably get more involved with web client development in the future. As for closing the application, in fullscreen you should be able to use ALT+F4. I wasn't able to reproduce the issue with the hamburger menu. It looks like an upstream fix for the always-on-top issue is in-progress with the library that provides the web window, so that should be available when they release. r0x0r/pywebview#476 |
Sounds good. Right Alt+F4 forgot about that. I'd have to program that to a button on the remote... but I guess I'd have to bring the keyboard out to work on anything at that point anyways, so may not be necessary. But unfortunately, without a switch user option it can't replace Plex yet. Unless I wanted to use Kodi again, which I kind of don't haha. Oh, also, I closed and opened the program several times, still get no hamburger menu in tv mode or in desktop mode. So not sure what went squirrely there. Thanks, and I appreciate the help! |
A lot has changed in the web client since this issue was opened. Please re-open this if the issue with TV mode is still present and isn't present in TV mode opened through a regular web browser. Same with the issue with the fullscreen window opening with always-on-top active. From my reading of the latest PyWebView source code, it looks like that should also be fixed based on the upstream code changes. User switching isn't something I can really control in the Web Client (remember that is an upstream project), but it is worth noting that if the usage is on your LAN, you can turn on the Easy PIN Code option to make switching easier. (Just use the PIN Code instead of a password.) |
I tried this out on my windows 10 htpc. The way I have plex setup is, windows boots and it goes directly into plex and proceed as normal.
When I load Jellyfin I cannot get it to be borderless fullscreen. There is always a border. If I do the windows key + up arrow, it resizes the window and I lose a good portion of the screen because it is hidden. It's a 4k tv that I do 150% scaling, however it didn't matter with scaling off it still sent 1/4 or so of the picture off screen. (this is the menu not the actual video player, the player works great).
I apologize if it's just my lack of knowledge, but is there some way to make the program itself full screen borderless? The 3 windows min max x is always visible in the top right.
Thanks for any help,
windows 10 (1909)
version 1.5.4
The text was updated successfully, but these errors were encountered: