Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make log level configurable #372

Closed
gudvinr opened this issue Mar 21, 2024 · 0 comments · Fixed by #379
Closed

Make log level configurable #372

gudvinr opened this issue Mar 21, 2024 · 0 comments · Fixed by #379
Labels
enhancement New feature or request

Comments

@gudvinr
Copy link

gudvinr commented Mar 21, 2024

Is your feature request related to a problem? Please describe.
jellyfin mpv shim is spamming in logs, which is especially noticeable when you launch it as daemon. That way, when you use journalctl, you get spammed by ping messages.

Right now, logging is hardcoded in log_utils.py by setting level for root_logger to DEBUG.

Describe the solution you'd like

There is mpv_log_level parameter already. Instead, log_level could be introduced, which can be applied to both mpv and shim itself. mpv_log_level can be either dropped or left to be used as additional parameter to override log levels for mpv.

Describe alternatives you've considered

  • Patching code myself
  • Writing logs to file (which are still verbose and take up space)
@gudvinr gudvinr added the enhancement New feature or request label Mar 21, 2024
gudvinr added a commit to gudvinr/jellyfin-mpv-shim that referenced this issue Apr 19, 2024
Use mpv_log_level to set shim logger level too.
That should remove excessive chatter from pings to the server.

Set level to INFO by default. During normal operations people
don't need to have debug enabled.

Fixes jellyfin#372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant