Fix episode metadata & improve series metadata #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After looking at metadata from other plugins, I found out that newlines need to be |
|
The show Zoku Owarimonogatari (13691) has links in the description with urls like this |
crobibero
reviewed
Mar 18, 2022
Jellyfin.Plugin.AniDB/Providers/AniDB/Metadata/AniDbEpisodeProvider.cs
Outdated
Show resolved
Hide resolved
Jellyfin.Plugin.AniDB/Providers/AniDB/Metadata/AniDbEpisodeProvider.cs
Outdated
Show resolved
Hide resolved
Jellyfin.Plugin.AniDB/Providers/AniDB/Metadata/AniDbEpisodeProvider.cs
Outdated
Show resolved
Hide resolved
Jellyfin.Plugin.AniDB/Providers/AniDB/Metadata/AniDbSeriesProvider.cs
Outdated
Show resolved
Hide resolved
crobibero
approved these changes
Mar 19, 2022
h1dden-da3m0n
approved these changes
Mar 19, 2022
|
@nalsai just before I hit the merege here, the branch is good or you have any other changes that you want to get in? |
|
It's good now 👍️ |
Merged
|
Thank you for your contribution 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the episode metadata by getting it using the season and episode number. #6
I added reading the summary from the episode xml, so that it can also be included in the metadata, and I added populating the ProductionYear for series metdata.
I also added AniDbReplaceGraves to a couple of places, where it was missing, and removing the * that is sometimes at the beginning of the series description (when it begins with "Based on").