Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native Japanese title to the original title field #4

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

ayyu
Copy link
Contributor

@ayyu ayyu commented Mar 13, 2021

No description provided.

@robertgzr
Copy link
Contributor

yo how about making it configurable? I had opened a pr on the original anime plugin that allowed you to set which language to pull into the original title field: jellyfin-archive/jellyfin-plugin-anime#92

@h1dden-da3m0n
Copy link
Contributor

Hi @ayyu and @robertgzr, thank you both for your contribution!
As far as I am concerned, we could merge this PR (once @ayyu squashes their commits) and continue with a followup to make this configurable?
Feel free to let me know what you want to do / think!

@h1dden-da3m0n h1dden-da3m0n added the feature This PR or Issue requests or introduces a new feature label Apr 9, 2021
…s preferred language

Signed-off-by: ayyu <ayyu@uwaterloo.ca>
Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being given the choice between romanji and kanji/kana as @robertgzr suggests would've been ideal, but I think this is fine for now.

@oddstr13 oddstr13 changed the title Add native Japanese title as original title when romaji/localized titles requested Add native Japanese title to the original title field Apr 13, 2021
@oddstr13 oddstr13 merged commit c921d69 into jellyfin:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This PR or Issue requests or introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants