Add User Settings Tests #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
reviewed
Dec 3, 2021
Import specific provider instead of filtering Capitalize log placeholders Co-authored-by: Cody Robibero <cody@robibe.ro>
1337joe
force-pushed
the
add-settings-tests
branch
from
a232b51
to
44549f5
Compare
|
Last thing I noticed- if I enter a totally invalid filter, such as |
Catch filter errors Display filter-specific error text on testing Handle unexpected (non-json) error messages
|
Error 500 returns a string, not json, so that took a bit of working around to ensure it would display. On the bright side, the filter error message contains the specific failure reason (not as the Message, but embedded in the ToString): |
crobibero
approved these changes
Dec 5, 2021
Merged
crobibero
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Screenshots
LDAP User Settings
Valid filters with matches
Empty user filter, admin warning
No user found
User found
Unable to search due to LDAP connection failure
Issues
Fixes #40