Add 'Enable All Folders' or selected folder list for LDAP user create #90
Conversation
|
It looks like the actions to build/run/test are requiring .net6, but the project is .net5 -- is there anything I can do on the PR to correct this? Is Jellyfin moving to .net6? Thanks, |
|
Yes, Jellyfin is now on dotnet6. If you rebase you'll have the 10.8 changes :) |
jketreno
force-pushed
the
folder-ldap-access
branch
from
ecc7ee9
to
0bf699e
Compare
|
Got it. Thanks. I rebased and updated my branch w/ a force push. Will the workflows auto re-trigger? Cheers, |
|
I haven't forgotten about this, just haven't had time to test the changes |
|
No worries; I'll resolve the new merge conflict and push an update later today. |
I needed to be able to limit new users to only have access to specific content on my network. I like the way editing of individual library access is performed, so extended that concept into the LDAP plugin configuration. THe HTML view is derived from jellyfin-web/src/controllers/dashboard/users/userlibraryaccess.html Signed-off-by: James Ketrenos <james_github@ketrenos.com>
Signed-off-by: James Ketrenos <james_github@ketrenos.com>
Signed-off-by: James Ketrenos <james_github@ketrenos.com>
Signed-off-by: James Ketrenos <james_github@ketrenos.com>
…ation' is disabled The visibility of Library Access wasn't being set during load based on the Enable User Creation state; instead it was only updating on change. Moved the code into a helper function for the event handler and call it during creation. Signed-off-by: James Ketrenos <james_github@ketrenos.com>
Signed-off-by: James Ketrenos <james_github@ketrenos.com>
jketreno
force-pushed
the
folder-ldap-access
branch
from
88480d8
to
73ac269
Compare
The 'pageshow' handler is executing any time any page is loaded. This patch adds an event filter at the start of 'pageshow' to only execute if the LDAP-Auth page is active. Signed-off-by: James Ketrenos <james_github@ketrenos.com>
|
I just pushed a rebased series. The indentation from the fix for #92 caused some hiccups in the merge. I also pushed a patch to prevent the 'pageshow' handler from executing when LDAP-Auth isn't the active page (so the document.querySelector references are all valid -- switching in and out of different views was eventually causing an undefined reference without the change.) I have this all running locally again, and verified new LDAP users only get the configured libraries enabled. Cheers, |
While this was working before, it has not been working with the latest version. Switching to filter from JavaScript instead of the selector is working now. Signed-off-by: James Ketrenos <james_github@ketrenos.com>
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Cody Robibero <cody@robibe.ro>
I needed to be able to limit new users to only have access to specific content on my network. I like the way editing of individual library access is performed, so extended that concept into the LDAP plugin configuration.
THe HTML view is derived from jellyfin-web/src/controllers/dashboard/users/userlibraryaccess.html
Signed-off-by: James Ketrenos james_github@ketrenos.com