Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Feed should differentiate between different comic book formats #38

Closed
rluetzner opened this issue Feb 14, 2024 · 2 comments

Comments

@rluetzner
Copy link
Contributor

I noticed that jellyfin-plugin-opds treats all comic book formats as application/x-cbr, but that is not correct. There are different file types, e.g. cbz, cb7, cbr. The file ending indicates which compression algorithm was used, although it can of course be misleading.

The examples above indicate the following compression algorithms:

  • cbz: Zip
  • cbr: Rar
  • cb7: 7Zip

This is a long introduction for the problem I observed: Rar is a proprietary algorithm and, while freely available, is usually not supported by FOSS eReader software (e.g. KOReader, Seeneva, ACV). So, if the feed claims that the comic book is in a proprietary format, most eReaders will not be able to download and display the books.

As I've said before, the file ending could be misleading, but as a first step, I would assume it is correct and assign the appropriate MIME type according to the file ending.

@rluetzner
Copy link
Contributor Author

Hold on. I just had a look at the code and to me it seems like Jellyfin itself is providing the wrong MIME type. At least I couldn't find any explicit mention of x-cbr or cbr anywhere.

@rluetzner
Copy link
Contributor Author

There's nothing to do. The bug is in a package dependency of the main Jellyfin project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant