Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error downloading subtitles #15

Open
diegodlh opened this issue Oct 25, 2019 · 7 comments
Open

Error downloading subtitles #15

diegodlh opened this issue Oct 25, 2019 · 7 comments
Labels
bug This PR or Issue describes or fixes something that isn't working feature This PR or Issue requests or introduces a new feature

Comments

@diegodlh
Copy link

diegodlh commented Oct 25, 2019

I am using version 6 of the Open Subtitles plugin and I am getting the same error message that was reported on (closed) bug #1424 of the jellyfin repository:

[2019-10-25 18:38:12.594 -03:00] [ERR] Error downloading subtitles from "Open Subtitles"
System.NullReferenceException: Object reference not set to an instance of an object.
at Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader.Login(CancellationToken cancellationToken)
at Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader.Search(SubtitleSearchRequest request, CancellationToken cancellationToken)
at MediaBrowser.Providers.Subtitles.SubtitleManager.<>c__DisplayClass11_0.<<SearchSubtitles>b__3>d.MoveNext()
This error message is triggered both when (i) I run the scheduled task to download subtitles, or (ii) I search for subtitles in a particular movie.
I tried with version 5 as well, and same error appears (after restarting the server). I also tried with and without username and password (it is hard to tell if my user and pass are being saved, because the fields are reset to blank after clicking "save" in the plugin settings).
The error appears if I request subtitle download both from Firefox browser, and from the Android app.

Bond-009 added a commit that referenced this issue Oct 27, 2019
dkanada added a commit that referenced this issue Oct 30, 2019
@anthonylavado
Copy link
Member

@diegodlh Have you tried with version 7 on the latest 10.4.2?

@gabri94
Copy link

gabri94 commented Dec 28, 2019

I have a very similar problem for the version 7 on 10.4.3
This is the error message i get while trying the download

 [ERR] Error downloading subtitles
   at MediaBrowser.Providers.Subtitles.SubtitleManager.DownloadSubtitles(Video video, LibraryOptions libraryOptions, String subtitleId, CancellationToken cancellationToken)

@gabri94
Copy link

gabri94 commented Dec 28, 2019

I enabled the logging and this is the full error trace:

MediaBrowser.Common.Extensions.RateLimitExceededException: OpenSubtitles rate limit reached
   at Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader.GetSubtitlesInternal(String id, PluginConfiguration options, CancellationToken cancellationToken)
   at MediaBrowser.Providers.Subtitles.SubtitleManager.DownloadSubtitles(Video video, LibraryOptions libraryOptions, String subtitleId, CancellationToken cancellationToken)
   at MediaBrowser.Api.Subtitles.SubtitleService.<>c__DisplayClass14_0.<<Post>b__0>d.MoveNext()

Since I haven't downloaded any subtitles today i created a new account to have an additional confirmation and i got the same error with the new account.

@anthonylavado
Copy link
Member

@gabri94 Just had a chance to look at this. OpenSubtitles limits by IP address, not by account, so changing accounts won’t get past it.

@anthonylavado
Copy link
Member

We’ll try to look at enabling better throttling protection in the plug-in, but ultimately the error is outside of our control.

@anthonylavado anthonylavado added bug This PR or Issue describes or fixes something that isn't working feature This PR or Issue requests or introduces a new feature labels Feb 20, 2020
@pmorch
Copy link

pmorch commented Mar 27, 2023

Is this a duplicate of #63 and fixed by #83?

@MBR-0001
Copy link
Contributor

I don't think it is a duplicate but I believe its safe to assume that the issue was fixed because the plugin was switched to the new REST API in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This PR or Issue describes or fixes something that isn't working feature This PR or Issue requests or introduces a new feature
Projects
None yet
Development

No branches or pull requests

5 participants