-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements #90
Conversation
Jellyfin.Plugin.OpenSubtitles/OpenSubtitlesHandler/OpenSubtitles.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume using a regular Directory
and a custom query builder is yields more performance?
And maybe a nit, but a negative test for that func would be cool, but I must not complain, I write way too few tests :S
@MBR-0001 you have been the quite active in this plugin, mind giving this another look? |
The custom query builder isn't for performance (although it may be faster) it's just less hacky then the current code. |
Thank you for clarifying, and I have to admit that I did not think of that nor would have been able to notice 😅 |
I ran a few tests and everything worked as expected, I didn't look at the moviehash code but it appears to be creating same hashes as before... The query string code follows all 5 (or 4? idk) rules and looks much cleaner (glad the %20 hack is gone lol) so, in conclusion, looks good 👍 |
No description provided.