Fix episode matching for sync from trakt task #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Trakt has switched from tvdb to tmdb as indexer - Episodes are often not aligned between tvdb and tmdb - Watched shows api does not contain episodes ids - History api does contain episode ids - If no matching is found by season and number (from shows api), fallback to history api to determine a match by episode ids
When an episode is not matched with the season, let's find it in any season. This happens when an episode of the next season in tvdb appears in the previous season in tmdb. (F.e. Hunter X Hunter S02E01 tvdb = S01E59 tmdb)
|
I ran this updated plugin on my whole library and now watched status is properly imported! 🥳 |
|
Works perfectly after adding the latest commit. 😉 |
Shadowghost
approved these changes
Nov 29, 2022
Not sure if you are following tvdb or tmdb seasoning... It's mainly a fix when seasoning is different. It now has a fallback to match by ids (instead of season and number) by using the history api from trakt. And it's a fallback, so existing logic still applies, I'm addtionally try to match further when no match is found on season and number. And I think a lot of people are still following tvdb, as it's the only indexer source used in the sonarr tool. 😉 |
crobibero
reviewed
Dec 4, 2022
crobibero
approved these changes
Dec 4, 2022
crobibero
added
bug
Merged
h3llrais3r
added a commit
to h3llrais3r/jellyfin-plugin-trakt
that referenced
this pull request
Mar 1, 2023
The history api includes more details (i.e. indexer id) which can be used to properly match episodes (i.e. when jellyfin is using other indexer than trakt). Matching by indexer id is a lot more accurate than matching by season and number. This is a rework of jellyfin#191 where we are now using the history by default for episode sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Fixes #190