chore(build): update analyzers #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddstr13
reviewed
Apr 7, 2021
| @@ -53,7 +63,11 @@ | |||
| <Rule Id="CA1822" Action="Info" /> | |||
| <!-- disable warning CA2000: Dispose objects before losing scope --> | |||
| <Rule Id="CA2000" Action="Info" /> | |||
| <!-- disable warning CA5394: Do not use insecure randomness --> | |||
There was a problem hiding this comment.
This one doesn't look like something we'd want to blanket disable? Should probably be done on a case-by-case basis.
I'll defer this decision to someone with a bit more knowledge about the linting rules.
There was a problem hiding this comment.
TBH I agree, however I used the jellyfin.ruleset from the server repo to update this one. That does not mean that it is flawless or that we should blanket use it everywhere.
However, I know to little about the linting rules myself to make the judgment so it ended up here 🤔
There was a problem hiding this comment.
alright, if it came directly from server it's probably fine
crobibero
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This aims to replace the FxCopAnalyzer with the .Net bundled Analyzer
Changes
Issues
edit:
There are a couple of white space diffs in this, sorry about this! With the introduction/update of the .editorconfig this was to be expected :S
edit2:
I had to add a couple of rule ignores to that I am not 100% sure on and would really appreciate a comment on before merging this.
Closes #24