-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should provide identifying info in its exception #47
Open
michaelkrieger
wants to merge
1
commit into
jellyfin:master
Choose a base branch
from
michaelkrieger:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Dec 28, 2022
-
Should provide identifying info in its exception
I'm getting the below error, obviously not liking a particular show. Likely this is some variation of TVDB vs TVMAZE where a season exists in one vs another. Without any information in the error logs, I have no idea where the problem lies. Can the Exception for GetMetaData please tell me the series, season, and episode in question (by Jellyfin ID, TVMaze ID, or even title) so we can actually debug these errors? I've done a proposed change with the name, but of course happy to use any other identifier which is appropriate. ``` [2022-12-28 13:21:27.459 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.475 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.490 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.510 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.535 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.553 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.566 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.581 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.602 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.624 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.639 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.653 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.671 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.686 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) [2022-12-28 13:21:27.702 -05:00] [WRN] [213] Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider: [GetMetadata] System.ArgumentException: season at TvMaze.Api.Client.Endpoints.Shows.ShowsEndpoint.GetEpisodeByNumberAsync(Int32 showId, Int32 season, Int32 episodeNumber) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadataInternal(EpisodeInfo info) at Jellyfin.Plugin.TvMaze.Providers.TvMazeEpisodeProvider.GetMetadata(EpisodeInfo info, CancellationToken cancellationToken) ```
Configuration menu - View commit details
-
Copy full SHA for 7850457 - Browse repository at this point
Copy the full SHA 7850457View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.