Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some settings need to be exposed to the user for ideal functionality #550

Closed
whiteowl3 opened this issue Apr 2, 2022 · 7 comments
Closed
Labels
enhancement New feature or request

Comments

@whiteowl3
Copy link
Contributor

whiteowl3 commented Apr 2, 2022

Describe the feature you'd like
a settings menu needs to be implemented somewhere that allows for certain program-wide settings to be set.
at issue for me at the moment:

  • drop graphical subtitles or transcode them
  • output hdr or transcode it
  • passthrough dd+ or transcode it
  • initialize client certificates or dont
  • pass dev-id header or dont
  • URL to use if we receive local http links (for now assume single port rp)

but there will probably be others.
all input on where that menu should be or anything else it should include is welcome and appreciated.

@debmint
Copy link
Contributor

debmint commented Apr 2, 2022

Possibly related to this issue:
I was just thinking this morning about how nice it would be for a user to set preferences which the server allows the user to set, such as order in which libraries are shown, etc.

@neilsb
Copy link
Member

neilsb commented Apr 2, 2022

I have the beginnings of a user preferences system done. Defined by a json file to make it easy to add etc.

Needs a little UI work and there is a focus issue, but other that it's functional.

Only set up to work with Boolean values (as that's what I was needing it for) but easy to add other types. Was going to add number, text and select as they were needed.

I'll try get it finished off and a PR submitted.

@whiteowl3
Copy link
Contributor Author

whiteowl3 commented Apr 25, 2022

@cewert cewert added the enhancement New feature or request label May 28, 2022
@cewert
Copy link
Member

cewert commented May 28, 2022

So the way this issue is written it will never get closed because you have so much going on in here. Can we break these up in separate issues? It would give you a chance to explain what they all do and why you think they're each important. And it would be nice to have a dedicated place to talk about each of these. Best way to implement them, relevant code etc. etc.

@whiteowl3
Copy link
Contributor Author

in my mind this issue is just waiting on the settings menu to be implemented, and could just be closed and replaced with more specific issues afterwards, but I don't see the problem that you are describing. certainly it could be broken out into a discussion or series of discussions ("core", "MTLS", and "strm" could be useful subdivisions) but, really i see no reason why we can't just discuss it here and then close the issue when everything is either implemented or rejected.

@whiteowl3
Copy link
Contributor Author

oh it looks like neil dropped his user settings menu in #583, quite a few weeks ago.

@whiteowl3
Copy link
Contributor Author

At this point I don't even remember why I wanted to force dd+ passthrough, so I will probably nix that if I can't recall. Other than that, everything else is just waiting on #668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants