-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to GitHub Actions #163
Conversation
70da756
to
14b2872
Compare
52ca951
to
b621dee
Compare
I forgot to mention why this is still a draft while it appears to work: I don't like how the linter issues are reported right now. Both actions used (android/checkstyle) have a different method of reporting and I'm not a fan of that. When I eventually finish the action I'll update this PR and port it over to the android/androidtv repositories as I intended from the start :) |
07d0195
to
fec4274
Compare
fec4274
to
70c9e7e
Compare
Most of the features this PR originally added have now been merged in separate pull requests (including some more things!). The only missing part is linting. Unfortunately GitHub annotations still suck so I'm not sure how to add that. From what I've read it's not possible to create more then 10 annotations using the actions toolkit without using the API. Using the API is not possible without a token though, which I don't want to add as that could provide access to the repository if someone creates a malicious pull request. |
The limitation seems to be 10 per file which seems fine to me. If you have more than 10 you should probably check it locally lol. |
It's 10 for all results with the toolkit, it uses the API in this PR so that's why more show up |
This PR:
Additional notes: