Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GitHub Actions #163

Closed
wants to merge 1 commit into from
Closed

Move to GitHub Actions #163

wants to merge 1 commit into from

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Dec 12, 2020

This PR:

  • Build & Test
  • Detekt lint results with problem matcher
  • Android lint results with problem matcher
  • Markdown lint results with problem matcher
  • Validate Gradle Wrapper
  • Automatically update Gradle Wrapper
  • Remove testing/building from Azure pipelines
  • Publish with GitHub Actions
  • Remove Azure 🎉

Additional notes:

  • We can remove Codacy from this repository as we now use linters via GitHub Actions.

@nielsvanvelzen nielsvanvelzen mentioned this pull request Dec 12, 2020
7 tasks
@nielsvanvelzen nielsvanvelzen force-pushed the gh-actions branch 4 times, most recently from 70da756 to 14b2872 Compare December 12, 2020 16:14
@nielsvanvelzen nielsvanvelzen changed the title Add GitHub Actions workflows Move to GitHub Actions Dec 12, 2020
@nielsvanvelzen nielsvanvelzen force-pushed the gh-actions branch 2 times, most recently from 52ca951 to b621dee Compare December 12, 2020 16:37
h1dden-da3m0n
h1dden-da3m0n previously approved these changes Dec 12, 2020
@nielsvanvelzen
Copy link
Member Author

I forgot to mention why this is still a draft while it appears to work: I don't like how the linter issues are reported right now. Both actions used (android/checkstyle) have a different method of reporting and I'm not a fan of that.
I started on my own action to fix this but ran into some limitations of the GitHub API so until I'll figure that out this PR is blocked.

When I eventually finish the action I'll update this PR and port it over to the android/androidtv repositories as I intended from the start :)

@nielsvanvelzen
Copy link
Member Author

Most of the features this PR originally added have now been merged in separate pull requests (including some more things!). The only missing part is linting. Unfortunately GitHub annotations still suck so I'm not sure how to add that.

From what I've read it's not possible to create more then 10 annotations using the actions toolkit without using the API. Using the API is not possible without a token though, which I don't want to add as that could provide access to the repository if someone creates a malicious pull request.

@thornbill
Copy link
Member

The limitation seems to be 10 per file which seems fine to me. If you have more than 10 you should probably check it locally lol.

@nielsvanvelzen
Copy link
Member Author

It's 10 for all results with the toolkit, it uses the API in this PR so that's why more show up

@nielsvanvelzen nielsvanvelzen mentioned this pull request Apr 11, 2021
@nielsvanvelzen
Copy link
Member Author

You win @Maxr1998, created an issue (#220) to track my awesome linter idea.

@Maxr1998 Maxr1998 deleted the gh-actions branch April 11, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Conflicts prevent merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants