Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for 1.0.0 version #193

Merged
merged 6 commits into from
Mar 22, 2021

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Mar 14, 2021

Closes #107
Closes #195

Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only one minor suggestion.

README.md Outdated Show resolved Hide resolved
nielsvanvelzen and others added 2 commits March 19, 2021 08:51
Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nielsvanvelzen
Copy link
Member Author

Thanks for the thorough review @Maxr1998, I noticed some lines still using the "api client" term so I updated those as well.

README.md Outdated
<a href="https://bintray.com/jellyfin/jellyfin-apiclient-java/jellyfin-apiclient-java">
<img alt="Bintray Release" src="https://img.shields.io/bintray/v/jellyfin/jellyfin-apiclient-java/jellyfin-apiclient-java.svg"/>
<a href="https://search.maven.org/search?q=org.jellyfin.sdk">
<img alt="Bintray Release" src="https://img.shields.io/maven-central/v/org.jellyfin.sdk/jellyfin-core.svg"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img alt="Bintray Release" src="https://img.shields.io/maven-central/v/org.jellyfin.sdk/jellyfin-core.svg"/>
<img alt="Maven Release" src="https://img.shields.io/maven-central/v/org.jellyfin.sdk/jellyfin-core.svg"/>

👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm stupid

@Maxr1998 Maxr1998 changed the title Create new README for 1.0.0 version Update README for 1.0.0 version Mar 22, 2021
@Maxr1998 Maxr1998 enabled auto-merge (squash) March 22, 2021 21:35
@Maxr1998 Maxr1998 merged commit 625a354 into jellyfin:master Mar 22, 2021
@nielsvanvelzen nielsvanvelzen deleted the readme-1.0.0 branch March 22, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the repository to jellyfin-sdk-kotlin Update the README
3 participants