Add linting in CI using Detekt with SARIF output #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
force-pushed
the
ci-lint-detekt-sarif
branch
from
793f928
to
0055cd5
Compare
nielsvanvelzen
commented
Apr 17, 2021
| uses: github/codeql-action/upload-sarif@v1 | ||
| if: ${{ always() }} | ||
| with: | ||
| sarif_file: . |
There was a problem hiding this comment.
The tool can only use a single directory/file as input and will recursively search for any .sarif file. Using . will use the project directory to search in, this will search all directories in the project which might be slow (relatively speaking) but it will at least find all sarif files, even if we add more tools.
nielsvanvelzen
commented
Apr 17, 2021
| @@ -70,5 +70,10 @@ subprojects { | |||
| buildUponDefaultConfig = true | |||
| ignoreFailures = true | |||
| config = files("$rootDir/detekt.yml") | |||
| basePath = rootDir.absolutePath | |||
There was a problem hiding this comment.
^ for relative paths in the linter output
nielsvanvelzen
commented
Apr 17, 2021
| @@ -10,7 +10,7 @@ object Plugins { | |||
| object Versions { | |||
| const val kotlin = "1.4.30" | |||
| const val binaryCompatibilityValidatorVersion = "0.5.0" | |||
| const val detekt = "1.14.2" | |||
| const val detekt = "1.16.0" | |||
There was a problem hiding this comment.
Sarif supported starting from 1.15, updated to latest
Closed
nielsvanvelzen
changed the title
nielsvanvelzen
force-pushed
the
ci-lint-detekt-sarif
branch
from
0055cd5
to
453ec08
Compare
h1dden-da3m0n
approved these changes
Apr 17, 2021
Maxr1998
approved these changes
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds linting using Detekt with SARIF files.
Part of #220