Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for PairExtensions #329

Merged
merged 4 commits into from Oct 9, 2021
Merged

Add tests for PairExtensions #329

merged 4 commits into from Oct 9, 2021

Conversation

nielsvanvelzen
Copy link
Member

  • Added tests for PairExtensions
    • the ones needing UUID's are jvm only
      • kotlin team plz add uuid to stdlib thank

Also fixes a bunch of other things:

  • some tests used the wrong packages
  • some tests contained visibility modifiers (explicitApi mode was applied to the complete project before migrating to KMPP)
  • some tests weren't formatted

@Maxr1998 Maxr1998 merged commit 01fd874 into jellyfin:master Oct 9, 2021
@nielsvanvelzen nielsvanvelzen deleted the more-tests branch October 9, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxr1998 Maxr1998 Maxr1998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nielsvanvelzen @Maxr1998