Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary exports #148

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Remove unnecessary exports #148

merged 1 commit into from
Mar 15, 2022

Conversation

thornbill
Copy link
Member

These exports really didn't improve the developer experience like I hoped... it just made things confusing to have the same models exported via different paths.

@codecov-commenter
Copy link

Codecov Report

Merging #148 (046af32) into master (9a94f5e) will decrease coverage by 16.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #148       +/-   ##
===========================================
- Coverage   99.76%   83.56%   -16.20%     
===========================================
  Files          17       17               
  Lines         428      426        -2     
  Branches       44       44               
===========================================
- Hits          427      356       -71     
- Misses          1       70       +69     
Impacted Files Coverage Δ
src/models/api/index.ts 0.00% <ø> (-100.00%) ⬇️
src/models/index.ts 100.00% <ø> (ø)
src/models/api/item-sort-by.ts 0.00% <0.00%> (-100.00%) ⬇️
src/models/api/base-item-kind.ts 0.00% <0.00%> (-100.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a94f5e...046af32. Read the comment docs.

@thornbill thornbill merged commit 8d75e53 into master Mar 15, 2022
@thornbill thornbill deleted the remove-unnecessary-exports branch March 15, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants