Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target ES6 properly #341

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Target ES6 properly #341

merged 2 commits into from
Dec 5, 2022

Conversation

ferferga
Copy link
Member

See my previous fix at generator: OpenAPITools/openapi-generator#10308

See https://www.typescriptlang.org/tsconfig#target and https://www.typescriptlang.org/tsconfig#module

Default:
CommonJS if target is ES3 or ES5,,ES6/ES2015 otherwise.

There's no tree shaking right now

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #341 (2554eaf) into master (12ff58b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   99.79%   99.79%   -0.01%     
==========================================
  Files          78       78              
  Lines         493      482      -11     
  Branches       52       46       -6     
==========================================
- Hits          492      481      -11     
  Misses          1        1              
Impacted Files Coverage Δ
src/api.ts 100.00% <0.00%> (ø)
src/jellyfin.ts 100.00% <0.00%> (ø)
src/discovery/discovery-service.ts 100.00% <0.00%> (ø)
src/models/recommended-server-issue.ts 100.00% <0.00%> (ø)
src/discovery/recommended-server-discovery.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note in the breaking changes section of the README also? Thanks!

tsconfig.json Outdated Show resolved Hide resolved
* Add the switch to ES6/ES2015 to the breaking changes section of the readme
* Add the switch to Axios v1 major version to the breaking changes section of the readme
@sonarcloud
Copy link

sonarcloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ferferga
Copy link
Member Author

ferferga commented Dec 4, 2022

@thornbill I took the liberty to also add the upgrade to Axios v1 at #300 to the breaking changes section.

I also used 0.8.0 as the next logical step, but please ping me if you want me to use another versioning and I can fix it without any problem.

@thornbill thornbill added the enhancement New feature or request label Dec 5, 2022
@thornbill thornbill merged commit f3af345 into master Dec 5, 2022
@thornbill thornbill deleted the es6 branch December 5, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants