New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add url encoding to header #564

Merged

thornbill merged 2 commits into jellyfin:master from zachwn:headerEncoding

Sep 27, 2023

Contributor

zachwn commented Sep 26, 2023

should fix #533


          Add url encoding to header

92795b2

codecov-commenter commented Sep 26, 2023 •

edited

Loading

Codecov Report

Merging #564 (bcb0642) into master (baad1e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          82       82           
  Lines         569      569           
  Branches       54       54           
=======================================
  Hits          565      565           
  Misses          3        3           
  Partials        1        1

Files	Coverage Δ
src/utils/authentication.ts	`100.00% <ø> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Member

nielsvanvelzen commented Sep 26, 2023

I think encodeURIComponent works better for these values

thornbill requested changes

View reviewed changes

Member

thornbill left a comment

encodeURIComponent should be used instead otherwise you could still have invalid characters in the value


          Fix header url encoding

bcb0642

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

thornbill approved these changes

View reviewed changes

thornbill merged commit 96f6d02 into jellyfin:master

7 checks passed

thornbill added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment