Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tray app to .NET 4.7.2 #128

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

anthonylavado
Copy link
Member

@anthonylavado anthonylavado commented May 31, 2024

This adds x64 Server 2019 support, for those who had issues.

We'll revisit a hybrid approach when we start building installer and tray for ARM.

Fixes #125 #119

Copy link
Member

@crobibero crobibero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does CI/nsis need to be updated for the subpath support?

@nielsvanvelzen
Copy link
Member

Doesn't the tray app try to find jellyfin.exe it its own directory (CWD)? That would obviously fail after this PR.

@anthonylavado
Copy link
Member Author

Does CI/nsis need to be updated for the subpath support?

NSIS does have paths for the tray app to make shortcuts, those are updated for the sub folder in here.

The CI has the same subfolder specified for the output which should mean it's okay.

@anthonylavado
Copy link
Member Author

Doesn't the tray app try to find jellyfin.exe it its own directory (CWD)? That would obviously fail after this PR.

Good catch, I'll update that.

@anthonylavado
Copy link
Member Author

anthonylavado commented Jun 1, 2024

@nielsvanvelzen Looks like we already covered that case a long time ago:

_executableFile = Path.Combine(_installFolder, "jellyfin.exe");

IIRC the tray app used to be in its own folder, a long time ago 🙂

@anthonylavado anthonylavado changed the title Move tray app to .NET 4.7.1 Move tray app to .NET 4.7.2 Jun 1, 2024
@anthonylavado
Copy link
Member Author

I just realized that windows-latest has a 4.7.2 targeting pack, but doesn't list it in .NET Core Tools (see here). Should I kick this back to 2019?

@anthonylavado anthonylavado merged commit 578c725 into jellyfin:master Jun 2, 2024
1 check passed
@anthonylavado anthonylavado deleted the net-framework branch June 2, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]: Warning for Windows Server 2019 users
3 participants