-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tray app to .NET 4.7.2 #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does CI/nsis need to be updated for the subpath support?
Doesn't the tray app try to find |
NSIS does have paths for the tray app to make shortcuts, those are updated for the sub folder in here. The CI has the same subfolder specified for the output which should mean it's okay. |
Good catch, I'll update that. |
@nielsvanvelzen Looks like we already covered that case a long time ago:
IIRC the tray app used to be in its own folder, a long time ago 🙂 |
I just realized that |
This adds x64 Server 2019 support, for those who had issues.
We'll revisit a hybrid approach when we start building installer and tray for ARM.
Fixes #125 #119